Ticket Details

Tweaking the Inspector class

PULL REQUEST Ticket (closed) 

###What happened:
- Some Inspector tests were failing on Windows, and some lines were not covered.

###What was expected:
- I reckon I was expected to fix them issues mentioned up above.

###Commits:
1. [Use PHP_EOL instead of \n when splitting lines, for better cross-platform compatibility](http://rad-dev.org/forks/svemir/lithium/commits/view/49816bdd31e964a9a97567d35d5e1ebaa729ff0d)

- [Increase Inspector code coverage](http://rad-dev.org/forks/svemir/lithium/commits/view/8be9397d8fc55d2c2a0a2505239d2cde8046ab19)
on 01.13.11 reported by: svemir owned by: daschl

Updates

on 01.13.11 by svemir 
Some pesky spaces sneaked into indentation in that last commit up there. Should I revert, or whoever merges stuff will take care of it?
on 01.14.11 by svemir 
Just noticed an issue with one of the new tests I added. Only happens when it runs with other tests together, which means my solution was not that good to begin with. I will revert some of the previous commits and update this issue with clean ones.
on 01.14.11 by svemir
  • description was changed
				

			


		
			

								
					on 01.14.11				
				
					by svemir				

			
				

					
Everything mentioned in my two previous comments has been handled. Two reverted commit links replaced in the ticket text with a single new commit. Commit #1 remains unchanged.
				

			


		
			

				(fixed)				
					on 07.04.11				
				
					by daschl				

			
				

					
  • owner was changed to daschl
    • 

  • status was changed to closed
    • 

  • resolution was changed to fixed
Thanks for the ticket. Actually your first commit is already merged into master, your second one is not but as far as i can see those lines are covered as well (although there are some exceptions that could be tested).

Feel free to submit a pull request if you want to increase the testing coverage based on the current master version.

Also, the Inspector tests are not failing on windows anymore :)

Thanks again!