Projects / Lithium

diff --git a/libraries/lithium/template/Helper.php b/libraries/lithium/template/Helper.php index 1042865..27bbc67 100644 --- a/libraries/lithium/template/Helper.php +++ b/libraries/lithium/template/Helper.php @@ -137,7 +137,7 @@ abstract class Helper extends \lithium\core\Object { $options += $defaults; if (in_array($key, $this->_minimized)) { - $isMini = ($value == 1 || $value === true || $value === 'true' || $value == $key); + $isMini = ($value == 1 || $value === true || $value == $key); if (!($value = $isMini ? $key : $value)) { return null; } diff --git a/libraries/lithium/tests/cases/template/HelperTest.php b/libraries/lithium/tests/cases/template/HelperTest.php index 1a4711d..0817871 100644 --- a/libraries/lithium/tests/cases/template/HelperTest.php +++ b/libraries/lithium/tests/cases/template/HelperTest.php @@ -88,6 +88,23 @@ class HelperTest extends \lithium\test\Unit { $this->assertEqual($expected, $result); } + public function testAttributeMinimization() { + $attributes = array('selected' => 1); + $expected = ' selected="selected"'; + $result = $this->helper->testAttributes($attributes); + $this->assertEqual($expected, $result); + + $attributes = array('selected' => true); + $expected = ' selected="selected"'; + $result = $this->helper->testAttributes($attributes); + $this->assertEqual($expected, $result); + + $attributes = array('selected' => 'true'); + $expected = ' selected="true"'; + $result = $this->helper->testAttributes($attributes); + $this->assertEqual($expected, $result); + } + public function testRender() { $params = array( 'context' => new MockRenderer(),