Commit: 1c9b3727f3ff9b29aa0bf8852d4d7b822316383e

Author: gwoo | Date: 2010-03-08 08:47:53 -0800
removing the used and abused \helper\Html::tag() method
diff --git a/libraries/lithium/template/helper/Html.php b/libraries/lithium/template/helper/Html.php index 108bfa9..5071f8f 100644 --- a/libraries/lithium/template/helper/Html.php +++ b/libraries/lithium/template/helper/Html.php @@ -208,26 +208,6 @@ class Html extends \lithium\template\Helper { } /** - * Returns a formatted block tag, i.e <div />, <span />, <p />. - * - * @param string $name Tag name. - * @param string $class the css class for the given tag - * @param string $content String content that will appear inside the div element. - * If null, only a start tag will be printed - * @param array $options Additional HTML attributes of the DIV tag - * @return string The formatted tag element - */ - function tag($name, $class, $content = null, array $options = array()) { - $defaults = array('escape' => true); - list($scope, $options) = $this->_options($defaults, $options += compact('class')); - - return $this->_render( - __METHOD__, ($content === null) ? 'tag-start' : 'tag', - compact('name', 'options', 'content'), $scope - ); - } - - /** * Creates a link to an external resource. * * @param string $type The title of the external resource diff --git a/libraries/lithium/tests/cases/template/helper/HtmlTest.php b/libraries/lithium/tests/cases/template/helper/HtmlTest.php index c446b94..4c9d5d3 100644 --- a/libraries/lithium/tests/cases/template/helper/HtmlTest.php +++ b/libraries/lithium/tests/cases/template/helper/HtmlTest.php @@ -417,52 +417,6 @@ class HtmlTest extends \lithium\test\Unit { $result = $this->context->scripts(); $this->assertTags($result, $expected); } - - /** - * Tests generation of block-level element (<div />). - * - * @return void - */ - public function testDivBlock() { - $result = $this->html->tag('div', 'class-name'); - $this->assertTags($result, array('div' => array('class' => 'class-name'))); - - $result = $this->html->tag('div', 'class-name', 'text'); - $this->assertTags($result, array('div' => array('class' => 'class-name'), 'text', '/div')); - - $result = $this->html->tag('div', 'class-name', '<text>'); - $this->assertTags($result, array( - 'div' => array('class' => 'class-name'), '&lt;text&gt;', '/div' - )); - - $result = $this->html->tag('div', 'class-name', '&text', array('escape' => false)); - $this->assertTags($result, array( - 'div' => array('class' => 'class-name'), '&text', '/div' - )); - } - - /** - * Tests paragraph generation. - * - * @return void - */ - function testPTag() { - $result = $this->html->tag('p', 'class-name'); - $this->assertTags($result, array('p' => array('class' => 'class-name'))); - - $result = $this->html->tag('p', 'class-name', 'text'); - $this->assertTags($result, array('p' => array('class' => 'class-name'), 'text', '/p')); - - $result = $this->html->tag('p', 'class-name', '<text>'); - $this->assertTags($result, array( - 'p' => array('class' => 'class-name'), '&lt;text&gt;', '/p' - )); - - $result = $this->html->tag('p', 'class-name', '&text', array('escape' => false)); - $this->assertTags($result, array( - 'p' => array('class' => 'class-name'), '&text', '/p' - )); - } } ?> \ No newline at end of file